Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leading whitespace in SQL blocks #45

Closed
joshtemple opened this issue Jan 13, 2021 · 0 comments · Fixed by #48
Closed

Fix leading whitespace in SQL blocks #45

joshtemple opened this issue Jan 13, 2021 · 0 comments · Fixed by #48
Labels
enhancement New feature or request
Milestone

Comments

@joshtemple
Copy link
Owner

In the LookML editor, SQL statements have a leading space (you can see the highlighted blue background). However, this is probably confusing for users, as they wouldn't think to insert a leading space when they write or modify the SQL statements, leading to confusion when the LookML is generated without one.

We could manage this automatically in the DictParser class by checking for the presence of leading whitespace and inserting a space if none is found.

@joshtemple joshtemple added the enhancement New feature or request label Jan 13, 2021
@joshtemple joshtemple modified the milestones: 1.1.0, 1.0.1 Jan 13, 2021
This was referenced Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant