Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly export all public functions and classes #362

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented Oct 29, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 29, 2023

@github-actions github-actions bot temporarily deployed to pull request October 29, 2023 03:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 29, 2023 04:03 Inactive
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696402c) 100.00% compared to head (8a6c05f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #362   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         5535      5535           
=========================================
  Hits          5535      5535           
Files Coverage Δ
starlette_admin/contrib/mongoengine/__init__.py 100.00% <100.00%> (ø)
starlette_admin/contrib/odmantic/__init__.py 100.00% <100.00%> (ø)
starlette_admin/contrib/sqla/__init__.py 100.00% <100.00%> (ø)
starlette_admin/contrib/sqlmodel/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jowilf jowilf merged commit 3a599b7 into main Oct 29, 2023
10 checks passed
@jowilf jowilf deleted the explicit-export branch November 6, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants