Adds AdminConfig to override app_title, logo_url in the templates.
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowilf
reviewed
Nov 4, 2023
I'm working on it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 5559 5568 +9
=========================================
+ Hits 5559 5568 +9
☔ View full report in Codecov by Sentry. |
hasansezertasan
changed the title
AdminConfig to override app_title, logo_url in the templates.
jowilf
requested changes
Nov 11, 2023
There was a problem hiding this comment.
Your changes look great. Please add get_admin_config to auth_provider and include a test case for it in test_auth. Thanks!
jowilf
approved these changes
Nov 14, 2023
This was referenced Dec 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out the
changed files, there is a good example.Resolves: #349