-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TinyMCEEditorField: support custom TinyMCE configuration #380
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I've added some comments; could you please review them?
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 5767 5779 +12
=========================================
+ Hits 5767 5779 +12 ☔ View full report in Codecov by Sentry. |
The changes you made don't seem to break anything. I was being cautious with all "if-else" things but I think that's the developer's job to be careful about it now. |
I'm not sure if my approach with
config
attribute is the right way to do it but its better than strict and its something...TinyMCE is quite configurable: Here are some examples: TinyMCE 6 examples | TinyMCE Documentation