Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sqlalchemy column_property #408

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Add support for sqlalchemy column_property #408

merged 5 commits into from
Dec 23, 2023

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented Dec 3, 2023

closes #335

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023 •
edited
Loading

🚀 Deployed on https://docs-preview-408--starlette-admin-docs-preview.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 3, 2023 23:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 3, 2023 23:48 Inactive
hasansezertasan
hasansezertasan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasansezertasan hasansezertasan mentioned this pull request Dec 4, 2023
Closed
@jowilf jowilf added this to the 0.13.0 milestone Dec 23, 2023
@github-actions github-actions bot temporarily deployed to pull request December 23, 2023 07:16 Inactive
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37a551c) 100.00% compared to head (ec6777a) 100.00%.

❗ Current head ec6777a differs from pull request most recent head 1622871. Consider uploading reports for the commit 1622871 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #408   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5765      5769    +4     
=========================================
+ Hits          5765      5769    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 23, 2023 07:44 Inactive
@jowilf jowilf changed the title Support for sqlalchemy column_property Add support for sqlalchemy column_property Dec 23, 2023
@jowilf jowilf merged commit 950bf13 into main Dec 23, 2023
7 checks passed
@jowilf jowilf deleted the column_property branch December 23, 2023 07:44
@jowilf jowilf mentioned this pull request Jan 16, 2024
Merged
@hasansezertasan
Copy link
Contributor

Partially resolves #344

@hasansezertasan hasansezertasan mentioned this pull request Jul 10, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasansezertasan hasansezertasan hasansezertasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Support for SQLAlchemy Models with column_property and hybrid_property
2 participants
@jowilf @hasansezertasan