Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support translation for login form placeholders #425

Merged
merged 15 commits into from
Dec 23, 2023
Merged

Support translation for login form placeholders #425

merged 15 commits into from
Dec 23, 2023

Conversation

hasansezertasan
Copy link
Contributor

No description provided.

@jowilf jowilf added this to the 0.13.0 milestone Dec 23, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (568cac5) 100.00% compared to head (6dd7daf) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5767      5767           
=========================================
  Hits          5767      5767

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasansezertasan
Copy link
Contributor Author

@jowilf Can you check it for one final time?

@jowilf jowilf changed the title Adds i18n locale to login form placeholders. Support translation for login form placeholders Dec 23, 2023
jowilf
jowilf approved these changes Dec 23, 2023
View reviewed changes
Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hasansezertasan

@jowilf jowilf merged commit 7937fd7 into jowilf:main Dec 23, 2023
6 checks passed
@jowilf jowilf mentioned this pull request Dec 23, 2023
Merged
@hasansezertasan hasansezertasan deleted the locale-improvements branch December 27, 2023 13:24
@hasansezertasan hasansezertasan mentioned this pull request Dec 27, 2023
Closed
@jowilf jowilf mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowilf jowilf jowilf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hasansezertasan @jowilf