-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create German translation #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question for maintainers: how can I minify the packaged versions of flatpickr
and momentjs
libraries similar to the existing localizations?
`msgfmt admin.po -o admin.mo`
@jowilf this is ready for review now :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 5817 5819 +2
=========================================
+ Hits 5817 5819 +2 ☔ View full report in Codecov by Sentry. |
This should be handle automatically. Have you followed all the steps described in the contribution guide? |
oh no, I didn't see the guide at all. thanks for pointing it out, will update the PR |
@jowilf updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @disrupted, for your contribution. And thank you, @irux, for reviewing it.
No description provided.