Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create German translation #523

Merged
merged 16 commits into from
Mar 25, 2024
Merged

Create German translation #523

merged 16 commits into from
Mar 25, 2024

Conversation

disrupted
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question for maintainers: how can I minify the packaged versions of flatpickr and momentjs libraries similar to the existing localizations?

`msgfmt admin.po -o admin.mo`
@disrupted disrupted marked this pull request as ready for review March 7, 2024 17:57
@disrupted
Copy link
Contributor Author

@jowilf this is ready for review now :)

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2540c51) to head (3078209).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5817      5819    +2     
=========================================
+ Hits          5817      5819    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowilf
Copy link
Owner

jowilf commented Mar 14, 2024

question for maintainers: how can I minify the packaged versions of flatpickr and momentjs libraries similar to the existing localizations?

This should be handle automatically. Have you followed all the steps described in the contribution guide?

@disrupted
Copy link
Contributor Author

question for maintainers: how can I minify the packaged versions of flatpickr and momentjs libraries similar to the existing localizations?

This should be handle automatically. Have you followed all the steps described in the contribution guide?

oh no, I didn't see the guide at all. thanks for pointing it out, will update the PR

@disrupted
Copy link
Contributor Author

@jowilf updated

@disrupted disrupted requested a review from jowilf March 18, 2024 17:58
Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @disrupted, for your contribution. And thank you, @irux, for reviewing it.

@jowilf jowilf merged commit 96c262a into jowilf:main Mar 25, 2024
9 checks passed
@disrupted disrupted deleted the lang/german branch March 25, 2024 09:45
@jowilf jowilf mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants