Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Changes #17

Open
arjes opened this issue Jul 26, 2011 · 6 comments
Open

Recent Changes #17

arjes opened this issue Jul 26, 2011 · 6 comments

Comments

@arjes
Copy link

arjes commented Jul 26, 2011

Hey,

Do you have any plans to add support for pulling recent changes? I know its available via the API, and I can implement it your not planning on doing it. its writing the specs that I'm not really familiar with.

@jpatokal
Copy link
Owner

No plans, so go for it.

@arjes
Copy link
Author

arjes commented Jul 27, 2011

Hey, I added the code for the RC and EmbededIn to my fork, but I haven't written any tests for them. I will see if I can figure it out the , but I'm not sure I will figure out the fake_media_wiki emulator thing.

I didn't change any of your code, so my fork shouldn't break anything, but I know you probably don't want un-tested code floating around :)

@jpatokal
Copy link
Owner

jpatokal commented Aug 6, 2011

Ta, will take a look once I get back from holidays next week.

@arjes
Copy link
Author

arjes commented Aug 7, 2011

I also needed to pull namespace lists, so added that function as well.

@arjes arjes closed this as completed Aug 7, 2011
@arjes arjes reopened this Aug 7, 2011
@arjes
Copy link
Author

arjes commented Aug 7, 2011

As an FYI I undid the namespaces, i didn't notice the namespaces_by_prefix, may want to alias that function to namespaces.

I also added some more SMW specific functions using the Special:Ask page instead of rendering the {{#ask: }} function since it returns a more useful data structure.

This is my first real practical code contribution in a while, so do your worst :)

@jpatokal
Copy link
Owner

Can you send me a pull request for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants