Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More info with integrations #179

Closed
xescugc opened this issue Mar 5, 2019 · 2 comments
Closed

More info with integrations #179

xescugc opened this issue Mar 5, 2019 · 2 comments
Assignees
@jpbruinsslot
Labels
enhancement

Comments

@xescugc
Copy link

xescugc commented Mar 5, 2019 •
edited
Loading

When a user uploads a file/image to slack (or use giphy hehe) or other integrations, the content it's hidden on slack-term.

For example with Trello integration the name of the user is <unknown> but on slack they show more info (title, card, board) IDK if that it's send thought.

On upload the content it's directly <unknown> only the titles is shown, if any. Would be good to have the slack URL for it.

For giphy it's the same as uploads, <unknown> and a title is what it was search with. This is not a requirement but just that it's the same behavior as the others so I would say that it would follow the same approach.

Seems related to #13 but IDK I still see it wrong.
@xescugc xescugc changed the title Slack URLS when shares Slack URLS when integrations Mar 5, 2019
@jpbruinsslot jpbruinsslot changed the title Slack URLS when integrations Image and file urls Mar 16, 2019
@jpbruinsslot jpbruinsslot self-assigned this Mar 16, 2019
@jpbruinsslot jpbruinsslot added this to the v0.4.2 milestone Mar 16, 2019
@jpbruinsslot
Copy link
Owner

jpbruinsslot commented Mar 16, 2019 •
edited
Loading

I'll have a look if I can at least get the url from file/image to show

@jpbruinsslot
Copy link
Owner

Added files download link to messages, that fixes the first part of the issue.

Second part, more info with integrations, I'll reopen the issue

@jpbruinsslot jpbruinsslot reopened this May 11, 2019
@jpbruinsslot jpbruinsslot changed the title Image and file urls More info with integrations May 11, 2019
@jpbruinsslot jpbruinsslot mentioned this issue May 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpbruinsslot jpbruinsslot

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xescugc @jpbruinsslot