Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename transformer and transformer builder classes #27

Open
vruusmann opened this issue Feb 8, 2019 · 0 comments
Open

Rename transformer and transformer builder classes #27

vruusmann opened this issue Feb 8, 2019 · 0 comments

Comments

@vruusmann
Copy link
Member

Current names org.jpmml.evaluator.spark.Transformer and o.j.e.s.TransformerBuilder are too vague - there is no clear indication that they deal with the PMML data format (as implemented by the JPMML-Evaluator library). Perhaps adding a common prefix such as "PMML" (or "Evaluator") would be all that is needed.

Renaming classes is a breaking API change, so it would necessitate upgrading the JPMML-Evaluator-Spark base version from 1.2.X to 1.3.X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant