-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpilation fails for SimpleSetPredicate
elements
#20
Comments
The transpiler has found a non-PMML object inside a PMML class model object, and currently does not know how to create a Java initializer code for it. This exception is about the contents of "set-type" array elements (implementing "value is contained in set" or "value is not contained in set"-type of business logic). The default representation of sets is
Looks like "standalone models" are transpiled successfully, while a "model plus set expression combinations" (the model uses an external The JPMML-Transpiler testing suite (inside
The evaluation and transpilation of PMML documents is schema version agnostic. What matters is whether the PMML document contains a |
isIn
and isNotIn
expression elements
Hi Villu, Thanks for swift reply and for looking into it. I can confirm your explanation, as I compared successful vs failed transpilation, the difference is indeed on the existence of <SimpleSetPredicate field="Occupation" booleanOperator="isIn">
<Array type="string">Clerical Executive Home Military Professional Protective Sales Support</Array>
</SimpleSetPredicate> |
The The problem is expected to happen with |
Hi Villu, I don't see any occurrence of |
That is strange. Anyway, the culprit is the The issue is probably easier to fix in JPMML-Transpiler code, that to keep triangulating it. The triangulation is currently only needed for building a relevant test case, in order to prevent this issue from re-happening again. |
isIn
and isNotIn
expression elementsSimpleSetPredicate
elements
This issue was about the All elements that were inside transpileable tree models were handled successfully. However, elements inside un-transpileable tree models, or elements outside of tree models, were failing. |
Thank you for the fix, will try it after this. EDIT: I compiled the git version and updated my test application to use snapshot, but now all those PMML throw this exception.
I'll wait until you make a release. Probably I'm doing it wrongly, pardon my lack of java skill. I hope you keep supporting ID10T (like me). 😀 |
Hello @vruusmann,
I was experimenting on the optimal way to implement models (whether using PMML or transpiled-PMML), then I found an error while transpiling few of PMML generated from the sample script on your blog ("Converting Scikit-Learn based LightGBM pipelines to PMML documents"). The error was:
Some of the generated PMML were successfully transpiled, however some of them were failed.
I took LightGBMAuditNA.pmml from your test data, and it's ok, however it was PMML 4.3, while the rest were 4.4.
Any hint for this error?
Thanks in advance.
Regards,
Agung
The text was updated successfully, but these errors were encountered: