Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esc shouldn't enter normal mode when focus is away from the editor itself #23

Open
munael opened this issue Dec 5, 2019 · 1 comment

Comments

@munael
Copy link

munael commented Dec 5, 2019

Scenario:

Have a tooltip or a panel open and press [esc] to close them. That works, but it also switches to normal mode.

Normal/Edit mode should be switchable only when the focus is solely on the editor.

@jpotterm
Copy link
Owner

jpotterm commented Dec 6, 2019

I can't reproduce this. SimpleVim uses VSCode's keybinding with "when": "editorTextFocus" which I think should give you the behavior you want. For example if I do the following steps it remains in insert mode:

  1. Enter insert mode
  2. Open VSCode's command palette
  3. Press escape

If you want to use a different when clause you can easily override the escape keybinding for SimpleVim via the normal VSCode keybinding method and use a different when clause. If you have a suggestion for a modified when clause to include as the default in SimpleVim let me know what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants