Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and plugins used by Maven #107

Closed
GoogleCodeExporter opened this issue Mar 29, 2015 · 5 comments
Closed

Update dependencies and plugins used by Maven #107

GoogleCodeExporter opened this issue Mar 29, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

The following dependencies in Dependencies have newer versions:
  com.google.guava:guava .................................. 17.0 -> 18.0
  joda-time:joda-time ....................................... 2.3 -> 2.7
  junit:junit ............................................. 4.10 -> 4.12

The following plugin updates are available:
  maven-antrun-plugin ...................................... 1.7 -> 1.8
  org.jacoco:jacoco-maven-plugin  0.7.0.201403182114 -> 0.7.2.201409121644
  org.pitest:pitest-maven .............................. 1.1.3 -> 1.1.4

I can submit pull requests for that if only you approve these updates.

Original issue reported on code.google.com by [email protected] on 11 Mar 2015 at 8:58

@GoogleCodeExporter
Copy link
Author

Hi,

I'm wondering -- all these dependencies are test scope. Did you run into any 
particular classpath issues?

BTW, I once tried to upgrade JUnit (I don't remember if it was to 4.11 or 
4.12), and ran into some unforeseen technical issues that I wasn't able to 
resolve quickly. For the other dependencies, I don't see any problems upgrading 
them. If you submit pull requests, I'd be very much obliged.


Jan

Original comment by [email protected] on 12 Mar 2015 at 2:48

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Hi,

Indeed update of JUnit causes build to fail. This could be investigated 
separately. For now I've raised pull requests for all other dependencies.

Regards,
Michal Kordas

Original comment by [email protected] on 13 Mar 2015 at 12:14

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Hi Michal,

Thanks for the pull requests. Next time though it would've been easier if it 
were just one pull request instead of many :). I've merged them all, but I did 
make some amendments on the 'remove unnecessary code' one, because I didn't 
agree with all of it. I like some things to be explicitly public or private, 
even if the language doesn't require the keywords to be there.

Regarding JUnit, I expected that would be the tough one. It's also the most 
worthwile one, because it's the only one that's actually really used. Guava, 
Joda-Time etc. are only there to provide example objects in unit tests, nothing 
more. So if you're still interested in figuring out the JUnit update, that 
would be very nice :).


Jan

Original comment by [email protected] on 15 Mar 2015 at 1:11

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Thanks! I've merged the upgrades, and some of the code improvements as well.

Original comment by [email protected] on 18 Mar 2015 at 9:13

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Hi Jan,

Thanks for the release! There were multiple commits so that you can choose what 
you like and have a flexibility what to merge. JUnit update went quite smoothly 
and I hope everything remains fine now.

Original comment by [email protected] on 28 Mar 2015 at 10:12

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant