Mark com.google.code.findbugs:annotations provided #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the "annotations" dependency does not end up on the classpath of dependant projects, which is nice for projects that e.g. use the jsr305 module instead. Note that complete absence of the annotations from the classpath does not matter at runtime.
jqno
added a commit
that referenced
this pull request
Mar 7, 2016
Mark com.google.code.findbugs:annotations provided
|
Good point, thanks for the PR! |
|
I've just made a new release that contains this PR. |
|
Thanks, tested it and works :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale outlined in the commit message:
Related is ronmamo/reflections#69, though in this case
jsr305is not a viable alternative due to the use of theSuppressFBWarningsannotation.