Generate distinct singleton enum collections

[Stephan202]

Currently, the following test fails:

public final class Test {
    @Immutable
    public static final class Dummy {
        public enum SingletonEnum {
            ELEM
        }

        private final ImmutableSet<SingletonEnum> values;

        Dummy(ImmutableSet<SingletonEnum> values) {
            this.values = values;
        }

        @Override
        public boolean equals(@Nullable final Object o) {
            return (o instanceof Dummy) && Objects.equals(this.values, ((Dummy) o).values);
        }

        @Override
        public int hashCode() {
            return Objects.hash(this.values);
        }
    }

    @Test
    public void testDummy() {
        EqualsVerifier.forClass(Dummy.class).verify();
    }
}

The error message is:

java.lang.AssertionError: Significant fields: equals does not use values, or it is stateless.
For more information, go to: http://www.jqno.nl/equalsverifier/errormessages
    at nl.jqno.equalsverifier.EqualsVerifier.handleError(EqualsVerifier.java:381)
    at nl.jqno.equalsverifier.EqualsVerifier.verify(EqualsVerifier.java:367)
    at com.example.Test.testDummy(TestTest.java:150)
    ...

This PR proposes a change which causes the test to pass, as it should. Interested to hear whether you think the approach taken is acceptable.

[coveralls]

Coverage increased (+0.004%) to 97.427% when pulling b52a7ae on PicnicSupermarket:generate-distinct-singleton-enum-collections into 820f10d on jqno:master.

[jqno]

Thanks for taking the time to make a PR! I'm on vacation right now, I'll
check it out when I get back.

equalsverifier/errormessages http://www.jqno.nl/equalsverifier/errormessages
at nl.jqno.equalsverifier.EqualsVerifier.handleError(EqualsVerifier.java:381)
at nl.jqno.equalsverifier.EqualsVerifier.verify(EqualsVerifier.java:367)
at com.example.Test.testDummy(TestTest.java:150)
...

This PR proposes a change which causes the test to pass, as it should.

Interested to hear whether you think the approach taken is acceptable.

You can view, comment on, or merge this pull request online at:

#157
Commit Summary

• Generate distinct singleton enum collections

File Changes

• M
  src/main/java/nl/jqno/equalsverifier/internal/prefabvalues/factories/CollectionFactory.java
  https://github.com/jqno/equalsverifier/pull/157/files#diff-0 (9)
• M
  src/test/java/nl/jqno/equalsverifier/internal/prefabvalues/factories/CollectionFactoryTest.java
  https://github.com/jqno/equalsverifier/pull/157/files#diff-1 (12)

Patch Links:

• https://github.com/jqno/equalsverifier/pull/157.patch
• https://github.com/jqno/equalsverifier/pull/157.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#157, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0osa0XH3g7bGusSLUK5VGJXBCDlrxJks5q0PvmgaJpZM4KXvmu
.

[jqno]

Looks good! Thanks again!
I have a few other issues to look at before I can make a release. I'll let you know when I do.

[jqno]

I've just released this fix in version 2.1.7.

Sorry for the delay!