Support for verifying a package and all sub-packages #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jqno
requested changes
Apr 16, 2021
There was a problem hiding this comment.
Hi! Thanks for the PR! This looks like a very useful feature to add, and the implementation looks quite clean: thanks!
I have one small question in the code though.
Also, would you mind running mvn spotless:apply so we can see some more green checks in GitHub Actions? :)
I'll definitely merge this if you do, and cut a release soon!
...test/java/nl/jqno/equalsverifier/integration/operational/MultipleTypeEqualsVerifierTest.java
Outdated
Show resolved
Hide resolved
jqno
approved these changes
Apr 19, 2021
|
Thank you very much for this PR. I've just released version 3.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new method
EqualsVerifier.forPackage(String packageName, boolean scanRecursively)to verify a given package and all sub-packages.This is useful when we organize our beans with sub-packages and don't want to forget to test a sub-package.
To String Verifier project offers an equivalent method:
https://github.com/jparams/to-string-verifier/blob/c5b1c6666d78b5fc7c9b07e81d48582b4d34fcb4/src/main/java/com/jparams/verifier/tostring/ToStringVerifier.java#L117