-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements needed to to be fully compatible with jQuery 3 #544
Comments
Hi Kevin! Thanks for this great plugin! Do you have any progress on updating it for jQuery 3? I have an issue using it, the selector is not working good : Thanks |
Hi again, I am not a pro on github so I create a fork and modified the code to work with jquery 3 : I replaced this.selector (which is now obsolete) by options.selector. So we need to provide the selector as an option : I don't know if it's the best way but it works for me Cheers |
Hi, any update on this? We are also upgrading our website to jQuery 3.3.1 and seeing issues with jQuery form plugin. Please let us know. |
Another warning from JQueryMigrate
|
@kevindb hi, guys. The library is used in Wordpress and it is one of the last ones with deprecated jQuery code, can you please replace the left instances of $.isFunction and make and update? |
It seems like @xaabi6 sneaked in last autumn and provided a pull request, that fixes all the deprecation nagging. @kevindb any chance, that you're having a look? The code changes seem reasonable and would be a big step forward. |
Any update to this yet? |
jQuery 3 is removing a lot of features that have been depreciated for a long time. Some of these are still in use by jQuery Form.
https://jquery.com/upgrade-guide/3.0/
I have very little experience working with jQuery Deferred or Promises, so pull requests and assistance in updating jQuery Form is greatly appreciated.
Known issues
success
anderror
Deferred methodshttps://jquery.com/upgrade-guide/3.0/#breaking-change-special-case-deferred-methods-removed-from-jquery-ajax
https://jquery.com/upgrade-guide/3.0/#breaking-change-deprecated-context-and-selector-properties-removed
Other related issues:
#527 feature for Deferred
#401 Submit only if a promise is resolved
The text was updated successfully, but these errors were encountered: