Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Proper support for lists with search filter and dividers #1139

Merged
1 commit merged into from
Feb 24, 2011

Conversation

ernesto-jimenez
Copy link
Contributor

Right now search filters apply also to dividers.

This commit changes the search filter implementation to ignore dividers and adds some logic to hide dividers without any shown rows.

@johnbender
Copy link
Contributor

merged!

As a quick side note I moved some of the variable names to camel case which is the project convention. Thanks!

@ernesto-jimenez
Copy link
Contributor Author

Great, thank you :)

Sorry for the camel case. Long day coding ruby and forgot that change. I'll be more careful the next time :)

BTW, just realised it'll probably be good to have another test case where we check that the shown list dividers correspond to the shown "buckets". We need to make sure we have a failing test if somebody changes the for to work in order.

I'll send the test today :)

@mahesh2000
Copy link

i want to be able to apply the list filter box to list items AND the content of list dividers. i put grouped "header" info into the divider and as i can't search on the divider, i am having to replicate the same data in each list item. i'd like to be able to sort the following list of universities (as an example) by the city they are in:

CHICAGO
U of Chicago
Loyola U

BOSTON
Harvard U
MIT
Tufts

is there a way to switch this behaviour on?

thanks!

mahesh

@johnbender
Copy link
Contributor

@mahesh2000

There isn't a way to do this with the library as it stands, but you're certainly welcome to add a feature request to the wiki page.

@mahesh2000
Copy link

how do i do that, request a feature?

thx,

Mahesh Viswanathan
[email protected]

On Wed, Oct 26, 2011 at 2:13 AM, John Bender <
[email protected]>wrote:

@mahesh2000

There isn't a way to do this with the library as it stands, but you're
certainly welcome to add a feature request to the wiki page.

Reply to this email directly or view it on GitHub:
#1139 (comment)

@johnbender
Copy link
Contributor

@mahesh2000

I went ahead and added it:

https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

Under listivew

@mahesh2000
Copy link

thank you!

Mahesh Viswanathan
[email protected]

On Wed, Oct 26, 2011 at 1:12 PM, John Bender <
[email protected]>wrote:

@mahesh2000

I went ahead and added it:

https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

Under listivew

Reply to this email directly or view it on GitHub:
#1139 (comment)

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants