Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

Timestamps are being escaped when used with Paperclip 4.2.1 #126

Closed
maxim opened this issue Jan 4, 2015 · 11 comments · Fixed by #133
Closed

Timestamps are being escaped when used with Paperclip 4.2.1 #126

maxim opened this issue Jan 4, 2015 · 11 comments · Fixed by #133

Comments

@maxim
Copy link

maxim commented Jan 4, 2015

The part right here:
https://github.com/jrgifford/delayed_paperclip/blob/master/lib/delayed_paperclip/url_generator.rb#L14-L18

Was fixed in Paperclip here: thoughtbot/paperclip@ecfb5e2

But it gets monkeypatched by delayed_paperclip.

@ScotterC
Copy link
Collaborator

ScotterC commented Jan 5, 2015

Thanks @maxim! Any chance you could PR that over?

@maxim
Copy link
Author

maxim commented Jan 5, 2015

@ScotterC Perhaps we should get rid of alias_method_chain, instead use inheritance to write our own UrlGenerator based on paperclip's. Maybe I'll try that as a less coupled way of integrating with paperclip, let's see how that'd look.

@maxim
Copy link
Author

maxim commented Jan 5, 2015

@ScotterC oh just noticed it's a module, nevermind, will look more into it

@maxim
Copy link
Author

maxim commented Jan 5, 2015

I added an unfinished pull request, explanation there #127

@ScotterC
Copy link
Collaborator

ScotterC commented Jan 5, 2015

👍 Thanks @maxim

@consti
Copy link

consti commented Jan 15, 2015

Thanks for looking into that @maxim - I'm running into the same issue and hope there'll be a working fix, soonish. Let me know if you need any help!

@ScotterC
Copy link
Collaborator

We'll let you know @consti! @maxim and I spent half of this past Sunday untangling the UrlGenerator. Hoping to have a revamped, cleaner piece of code soon

@roymckenzie
Copy link

@maxim and @ScotterC, is this open issue related to why I am seeing:

imagename.jpg%3F1421493843 instead of imagename.jpg?1421493843 and my images are broken?

If it is not related I can open up a new issue.

Thank you for actively maintaining this gem! I'm looking forward to using it!

@consti
Copy link

consti commented Jan 17, 2015

imagename.jpg%3F1421493843 instead of imagename.jpg?1421493843 and my
images are broken?

Exactly, that's the issue! :)

@maxim
Copy link
Author

maxim commented Jan 17, 2015

Until we push the fix it's best to lock into paperclip no greater than 4.2.0.

@roymckenzie
Copy link

Thanks @maxim!

ScotterC added a commit to ScotterC/delayed_paperclip that referenced this issue Feb 6, 2015
Swaps the timestamp and escaping methods

Fixes jrgifford#126
andreslucena added a commit to nolotiro/nolotiro.org that referenced this issue Apr 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants