This repository has been archived by the owner on Oct 5, 2018. It is now read-only.
Deprecate Resque, Sidekiq and DelayedJob adapters. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better maintenance of gem `delayed_paperclip` will only support `ActiveJob` adapter which is available by default since Rails 4.2. It's possible to use any of this 3 background job adapters through AJ.
| @@ -8,6 +9,11 @@ class DelayedJob < Struct.new(:instance_klass, :instance_id, :attachment_name) | |||
| if Gem.loaded_specs['delayed_job'].version >= Gem::Version.new("2.1.0") | |||
|
|
|||
| def self.enqueue_delayed_paperclip(instance_klass, instance_id, attachment_name) | |||
| ActiveSupport::Deprecation.warn(<<-MESSAGE) | |||
There was a problem hiding this comment.
@morgoth did you have a chance to double check whether this shows up in the main server log and not just background job logs?
There was a problem hiding this comment.
Yes, it shows on server logs, as it's done when enqueuing, not performing.
|
If there are no blockers, please merge and release 2.10 |
|
@morgoth 2.10 pushed into the wild |
morygonzalez
pushed a commit
to morygonzalez/delayed_paperclip
that referenced
this pull request
Sep 28, 2016
Deprecate Resque, Sidekiq and DelayedJob adapters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better maintenance of gem
delayed_paperclipwill only supportActiveJobadapter which is available by default since Rails 4.2.It's possible to use any of this 3 background job adapters through AJ.
@ScotterC Please take a look if we are on the same page.
In version 3.0:
If that's the plan, can you please merge it and release 2.10.0 with this deprecation warnings?