Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature your Orchard Core module in a Orchard Skills Video. #1

Open
OrchardSkills opened this issue Jan 13, 2021 · 12 comments
Open

Feature your Orchard Core module in a Orchard Skills Video. #1

OrchardSkills opened this issue Jan 13, 2021 · 12 comments

Comments

@OrchardSkills
Copy link

OrchardSkills commented Jan 13, 2021

Hello Jhovani Salgado,

My name is William from Orchard Skills. I would like to feature your Orchard Core Module in a video. Can I please get your consent? I will make sure you get all the credit for the module. I will place a link to your GitHub repository along with any license you prefer in the video description. Please let me know. I would also like to collaborate with you to add new features.

Great Job!

Sincerely
William from Orchard Skills.

@jsalgado10
Copy link
Owner

Hello William

Thank you for taking interest in my Orchard Module. I am fine with you featuring my module in a video and welcome your collaboration on this project.

Thanks

@OrchardSkills
Copy link
Author

Hello Jhovani Salgado,

Thanks Jhovani Salgado. I'm working on the video now. I did come into an issue integrating with our Material Design Theme.
Do you have a NuGet package for your Orchard Core Module OrchardCore.Commentator? I updated your module to the latest Orchard Core Nuget packages from the Dev Preview Feed. I tested it with the Blog Theme and everything works but when I used the Orchard Skills Material Design Theme I get the error "Failed to load resource: the server responded with a status of 403" Access forbidden? Do you know any reason why I'm getting this error? Since I couldn't find a NuGet package I add your code to the GitHub Repository for testing: https://github.com/OrchardSkills/OrchardSkills.OrchardCore.Commentator I will be happy to remove your code from the repository once integrated.

@jsalgado10
Copy link
Owner

Hello Jhovani Salgado,

Thanks Jhovani Salgado. I'm working on the video now. I did come into an issue integrating with our Material Design Theme.
Do you have a NuGet package for your Orchard Core Module OrchardCore.Commentator? I updated your module to the latest Orchard Core Nuget packages from the Dev Preview Feed. I tested it with the Blog Theme and everything works but when I used the Orchard Skills Material Design Theme I get the error "Failed to load resource: the server responded with a status of 403" Access forbidden? Do you know any reason why I'm getting this error? Since I couldn't find a NuGet package I add your code to the GitHub Repository for testing: https://github.com/OrchardSkills/OrchardSkills.OrchardCore.Commentator I will be happy to remove your code from the repository once integrated.

William

There is no NuGet package yet as the module is still in progress. The module was tested using the release version 1.0.0-rc2-13450 of Orchard Core. I will download your repository and figure out what the issues is.

Thanks

@OrchardSkills
Copy link
Author

Hello Jhovani Salgado,

It's working just fine. I forgot to log in. I believe this is normal behavior. Maybe adding a message to log in to submit a comment will help.

@jsalgado10
Copy link
Owner

jsalgado10 commented Jan 13, 2021

Hello Jhovani Salgado,

It's working just fine. I forgot to log in. I believe this is normal behavior. Maybe adding a message to log in to submit a comment will help.

William

Good catch on this. I will make the change to display a message if the user is not authorize. If you want to allow comments on any user, then you can set the permission to post Comments on the Anonymous Role

image

@OrchardSkills
Copy link
Author

Awesome. You might also want to use ChallengeOrForbid() instead of Forbid();.

@OrchardSkills
Copy link
Author

OrchardSkills commented Jan 13, 2021

image

Is there a feature to delete a comment as Admin? In case someone needs to moderate the comments.

@jsalgado10
Copy link
Owner

Currently there is no admin dashboard to maintain the comments. I have updated the Readme on the repo with pending features

@OrchardSkills
Copy link
Author

Hello Jhovani Salgado,

If you have requirements on your new features I can help out. One option is to add a workflow to add a link of your comments to the dashboard. I posted a video on your module.
image
https://youtu.be/6DC7a-j8uRQ

@jsalgado10
Copy link
Owner

jsalgado10 commented Jan 14, 2021

William

Below are the requirements for each feature

Admin Dashboard to maintain Comments

  • There is a Comments Controller where all the CRUD operations need to be. There is a List, and Create method already. Need to add Edit, Delete and ListAdmin

Pager on Comment List

  • The pager has been implement on the comment list, but it

Handle unathorize user. Add a message or pop up

  • No specific requirements. Any feedback is welcome

Email Notifications

  • A contecthandler and a new User Profile view and display driver have been added. The Content handler will be used to send the notification based on the User's preference

@OrchardSkills
Copy link
Author

OrchardSkills commented Jan 14, 2021

image

You might want to consider following how YouTube manages comments. They have a very nice interface. It consists of a right-side navigation menu "Comments". It has a tab view on the left for "Published" and "Held for review" with a filter. You can take advantage of all the CRUD features from the Admin editors in the dashboard. I would add a reCAPTCHA for unauthorized users to try to avoid bots from creating advertisements in the comments. I like how YouTube has a notification when comments are posted. Also, you may want to consider requirements for settings in the admin dashboard for your module.

@jsalgado10
Copy link
Owner

I like the design of that dashboard. Will use that as a base for the comments admin dashboard
Yes I agree there needs to be a requirement of reCAPTCHA to anonymous post.
The settings are available on the commentator part on the Content Type. Here you can specify the editor to use, grouping, ordering and page count.
There also needs to be a place for global settings such as Api key for reCAPTCHA, actions on posted messages (published or review), etc.
As far as notifications, Email was what I started working on first, then move on to web site notifications maybe using SignalR.

Thank you for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants