Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size? #105

Closed
rayshan opened this issue Sep 13, 2020 · 1 comment · Fixed by #108
Closed

Reduce bundle size? #105

rayshan opened this issue Sep 13, 2020 · 1 comment · Fixed by #108

Comments

@rayshan
Copy link

rayshan commented Sep 13, 2020

Thanks for building datebook! I was really looking forward to using it until I saw the bundle size. 30 kb minified + gzipped is almost as big as React. Any thoughts on reducing the bundle size?

What do you think about removing moment and let users format their own dates? Here's a related library that uses this approach: https://github.com/jasonleibowitz/react-add-to-calendar-hoc nevermind I see that moment is only used for tests.

@rayshan rayshan changed the title Reduce bundle size, remove moment? Reduce bundle size? Sep 13, 2020
@jshor jshor linked a pull request Sep 16, 2020 that will close this issue
@jshor
Copy link
Owner

jshor commented Sep 16, 2020

Sorry for this oversight. Looks like the mode was set to development, which caused the source map to be part of the bundle. This will be fixed in the next minor release.

The bundle size should be reduced from 108KB to 16KB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants