Continue scanning for ';' in broken parameter values even beyond a \r…

… or \n
jstedfast · Aug 11, 2015 · fc98384 · fc98384
1 parent 157eca0
commit fc98384
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/MimeKit/ParameterList.cs b/MimeKit/ParameterList.cs
@@ -735,7 +735,7 @@ static bool TryParseNameValuePair (ParserOptions options, byte[] text, ref int i
 				// Note: Google Docs, for example, does not always quote name/filename parameters
 				// with spaces in the name. See https://github.com/jstedfast/MimeKit/issues/106
 				// for details.
-				while (index < endIndex && text[index] != (byte) ';' && text[index] != (byte) '\r' && text[index] != (byte) '\n')
+				while (index < endIndex && text[index] != (byte) ';')
 					index++;
 			}
 

diff --git a/UnitTests/ContentDispositionTests.cs b/UnitTests/ContentDispositionTests.cs
@@ -67,7 +67,7 @@ public void TestMistakenlyQuotedEncodedParameterValues ()
 		[Test]
 		public void TestUnquotedFilenameParameterValues ()
 		{
-			const string text = "attachment; filename=Partnership Marketing Agreement Form - Mega Brands - Easter Toys - Week 11.pdf";
+			const string text = "attachment; filename=Partnership Marketing Agreement\n Form - Mega Brands - Easter Toys - Week 11.pdf";
 			ContentDisposition disposition;
 
 			Assert.IsTrue (ContentDisposition.TryParse (text, out disposition), "Failed to parse Content-Disposition");