Include WindowsSecureMimeContext in .NET Standard 2.x build #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use System.Security.Cryptography.Pkcs in .netstandard2 build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
System.Security.Cryptography.Pkcspackage, theWindowsSecureMimeContextand related classes can be used together with .NET Standard. This PR changes the csproj-File for MimeKit, including these classes and the package into the build for .NET Standard 2.0.There might be some limitations when using this context on Linux / OS X, as the underlying
X509Storeused for storing / receiving has some limitations. However, at least for my use case (verifying / signing via S/MIME using the OS root certificates; as well as importing certs into the store and using them for en-/decryption), this works fine (using Debian Buster and Ubuntu Focal).We maybe should add a note concerning this into the docs, but I'd like to hear your thoughts on this first.