Added improved error reporting for ArcVerifier #593
Conversation
There was a problem hiding this comment.
Changes look really good and should perfectly address my use case.
One un related comment currently ArcSignAsync will fail if any cv=fail i can foresee a use case where just because a one item in the chain has failed validation does not mean you dont want to continue the chain. Im bring it up as its something i have seen is i=1 cv=none i=2 cv=fail i=3 cv=pass where i=2 recalculates the authentication and does not trust the auth passed by i=1 but continues the chain, its not something i have a use case for but though it was worth bringing up.
|
That's always been the case, but I get what you are saying. I'll change that if/when someone needs it. I believe the spec says not to sign when that's the case, but it's been a while since I looked, so I could be wrong. Not sure why I would have added that logic otherwise. |
Fixes issue #591