Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not checking for prop-types validation #2011

Closed
AnthonyLamot opened this issue Oct 8, 2018 · 1 comment
Closed

not checking for prop-types validation #2011

AnthonyLamot opened this issue Oct 8, 2018 · 1 comment
Labels

Comments

@AnthonyLamot
Copy link

When I leave out PropTypes I don't get the expected error.

I thought this might've been related to #1958, but when I downgraded to 7.10.0 it made no difference.

I've been away from React for a couple of months but I really miss these Eslint errors now! 😄

Note that I created my app using create-react-app. Not sure if that's causing the problem?

devDependencies:

  "devDependencies": {
    "eslint": "^5.6.1",
    "eslint-config-airbnb": "^17.1.0",
    "eslint-plugin-import": "^2.14.0",
    "eslint-plugin-jsx-a11y": "^6.1.2",
    "eslint-plugin-react": "7.10.0"
  }

Config:

{
    "extends": ["extends:airbnb", "eslint:recommended", "plugin:react/recommended"],
    "rules": {
        "react/jsx-filename-extension": [2, { "extensions": [".js", ".jsx"] }],
        "implicit-arrow-linebreak": ["warning", "beside"],
        "react/proptypes": [1],
        "react/forbid-prop-types": [0]
    },
    "settings": {
        "react": {
        "createClass": "createReactClass",
        "pragma": "React", 
        "version": "15.0",
        "flowVersion": "0.53"
        },
        "propWrapperFunctions": [ "forbidExtraProps" ]
    },
    "plugins": [
        "react"
      ]
}
@AnthonyLamot
Copy link
Author

Added extends: too much. 🦆

@ljharb ljharb added the invalid label Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants