Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal: Split jsx-sort-props into separate rules #738

Closed
klzns opened this issue Aug 3, 2016 · 3 comments
Closed

Rule proposal: Split jsx-sort-props into separate rules #738

klzns opened this issue Aug 3, 2016 · 3 comments
Labels

Comments

@klzns
Copy link

klzns commented Aug 3, 2016

I love the options of jsx-sort-props like callbacksLast, but the alphabetical thing is not what I'm looking for.

I think it would be great to split the options into separate rules, like:

  • jsx-sort-props-callbacksLast
  • jsx-sort-props-shorthandFirst
  • jsx-sort-props-shorthandLast
  • jsx-sort-props-alphabetical (the jsx-sort-props we have today)
@ljharb
Copy link
Member

ljharb commented Aug 3, 2016

It seems like this would be better solved by an option on the main rule to disable alphabetical sorting. I don't think it's a good idea to have multiple rules that directly conflict/overlap.

@klzns
Copy link
Author

klzns commented Aug 8, 2016

@ljharb that's a good option. I would be happy with that

@HenriBeck
Copy link

#786

@ljharb ljharb closed this as completed Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants