Add new deprecations from 15.5.0 #1148
Conversation
|
(linking to #1144) |
|
Actually destructuring is not handled for any deprecation in this rule. Mainly because it was not something common at the time it was written. So I think it should not be a blocker for this PR. But, since it is now a very common pattern, I'm working on a patch to add destructuring support to the whole rule. |
lib/rules/no-deprecated.js
Outdated
| @@ -64,6 +64,9 @@ module.exports = { | |||
| deprecated.MemberExpression['Perf.printDOM'] = ['15.0.0', 'Perf.printOperations']; | |||
| deprecated.MemberExpression['ReactPerf.getMeasurementsSummaryMap'] = ['15.0.0', 'ReactPerf.getWasted']; | |||
| deprecated.MemberExpression['Perf.getMeasurementsSummaryMap'] = ['15.0.0', 'Perf.getWasted']; | |||
| // 15.5.0 | |||
| deprecated.MemberExpression['React.createClass'] = ['15.5.0', 'the npm module create-react-class']; | |||
| deprecated.MemberExpression['React.PropTypes'] = ['15.5.0', 'the npm module prop-types']; | |||
There was a problem hiding this comment.
Please use the pragma variable instead of the hardcoded React string (you can take the other deprecation as example).
There was a problem hiding this comment.
Pragma would match if there is other thing than React.* used right?
I don't think it should match if this is from another object than React.
There was a problem hiding this comment.
pragma will match other thing than React only if the user has customized it to match something else (with a comment or using the shared settings).
There was a problem hiding this comment.
Got it 👍 PR updated
|
@yannickcr i'm fine with not handling destructuring in this PR (especially if you're working on adding it asap), but named imports should be handled, no? |
|
@ljharb like destructuring, it's something that was not handled by the rule, so I think it should be done separately from this PR. But my patch is almost ready, I should submit it tomorrow (I hope we'll be able to ship React 15 support this week). |
Added more deprecations rules regarding last react update.
But it does not seem to match patterns like this:
Any idea on how we can match those too?