[New] add checked-requires-onchange-or-readonly rule

[jaesoekjjang]

Resolved #3143

Hi, I added a new rule to enforce using onChange, readOnly props with checked.
How is it? And, any better naming for this rule?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4edc1f0) 97.74% compared to head (3dfaaeb) 97.75%.

❗ Current head 3dfaaeb differs from pull request most recent head b9292b4. Consider uploading reports for the commit b9292b4 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3680   +/-   ##
=======================================
  Coverage   97.74%   97.75%           
=======================================
  Files         132      133    +1     
  Lines        9420     9458   +38     
  Branches     3456     3464    +8     
=======================================
+ Hits         9208     9246   +38     
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ljharb]

Can you elaborate on why?

[jaesoekjjang]

Can you elaborate on why?

Sorry I'm no good at English. Are you asking about why this rule is necessary?

If it is, the answer is that there have been some times, using checked without onChange, and forgot to include readOnly like the code below

<tr onClick={toggleChecked}>
  <td>
     <input type='checkbox' checked={checked}/> 
  </td>
</tr>

Since there were no warns in the editor, I found bunch of red messages in the console later.
I guess the issue creator was also necessary for the same reason

[ljharb]

Yes - but why would a checkbox always need to have an onChange or readOnly? If that's not a valid use case, why doesn't React warn on it? What's wrong with a checkbox that doesn't have any behavior - perhaps it's part of a larger form that gets submitted normally.

[jaesoekjjang]

Checkbox doesn't need to have one of them always. The rule is checkingchecked property.
React warns on it in a console like this.

And this is the reason I thought it is necessary. To be warned earlier in editor.

I'm confusing, didnt' you labled accpeted, helpwanted, new rule on the issue #3143

[jaesoekjjang]

So... do you think is it good to go or no? I can close the pr if it's not

[ljharb]

Thanks for the reminder, that was 3 years ago :-) Let me give it a rereview.

[ljharb]

The only comment that's a blocker is the coverage one, i can clean up the rest if you don't feel like it :-)

[jaesoekjjang]

The only comment that's a blocker is the coverage one, i can clean up the rest if you don't feel like it :-)

Sure, appreciate it 😊