Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniqueness validation should be removed. #1

Open
qubyte opened this issue Mar 26, 2014 · 0 comments
Open

Uniqueness validation should be removed. #1

qubyte opened this issue Mar 26, 2014 · 0 comments

Comments

@qubyte
Copy link

qubyte commented Mar 26, 2014

This defect was first logged here, but since it is now specific to the validations module I'll echo it here.

tl;dr - Uniqueness cannot be asserted the way it is here, since it is prone (and this happens often in the wild so it's not just theoretical) to race conditions. The function is not reliable, and therefore worse than useless and should be removed. Uniqueness should be provided by each adaptor, probably delegating to the database. e.g. in the case of redis-hq this would be implemented as a lua stored procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant