[AUTO] Format files using DocumentFormat #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -822,7 +822,7 @@ function set_variable_request(conn, state::DebuggerState, params::SetVariableArg | |||
|
|
|||
| if var_ref.kind == :scope | |||
| try | |||
| ret = JuliaInterpreter.eval_code(var_ref.value, "$var_name = $var_value"); | |||
| ret = JuliaInterpreter.eval_code(var_ref.value, "$var_name = $var_value") | |||
There was a problem hiding this comment.
Shouldn't remove the trailing ;.
There was a problem hiding this comment.
does removing it change the semantics of the program?
There was a problem hiding this comment.
No, but that can't be the criterion, there are countless changes that one could make that don't change the semantics program.
I think we had agreed that the minimal formatter that we want to have in the extension should change whitespacing, indentation and nothing else. In particular, it should never add or remove any other characters that a user wrote.
Obviously this is a great feature to have available in a style and as an option.
src/protocol/events.jl
Outdated
| @@ -1,5 +1,4 @@ | |||
| @dict_readable struct InitializedEventArguments <: Outbound | |||
| end | |||
| @dict_readable struct InitializedEventArguments <: Outbound end | |||
There was a problem hiding this comment.
Shouldn't remove the line break.
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
b7b870a
to
cdb3fef
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
cdb3fef
to
a19244a
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
a19244a
to
67b3d12
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
e5cdf5a
to
acb4727
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
acb4727
to
f4726a2
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
3 times, most recently
from
81bbecb
to
0443fe4
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
0443fe4
to
61751ad
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
61751ad
to
c14c32d
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
c14c32d
to
8616ca0
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
8616ca0
to
a7b5e6b
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
a7b5e6b
to
7360891
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
8 times, most recently
from
0840536
to
2f3fa64
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
3 times, most recently
from
b22f0b6
to
035310f
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
035310f
to
f88d59b
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
c0ef0ea
to
9d35b0a
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
9d35b0a
to
133a5e2
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
133a5e2
to
9bed7b4
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
9bed7b4
to
513ae29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentFormat.jl would suggest these formatting changes