A bunch of fixes from production usage #3 #31
Conversation
…is written and read from different threads
As per https://www.rfc-editor.org/rfc/rfc4566#section-6: "recvonly" should be the default for "type:broadcast" sessions.
…able, permissions denied, etc.)
Before this change we can't ensure streams are stopped (pool threads completed). Now we can await till streams stopped. Also we improved streams start time as we start them in parallel.
|
Mostly LGTM, will take another look shortly as I have started rebasing the other branch like 3 times already and I think it will be easier to merge this first. Thanks for your contributions! |
| @@ -1327,7 +1320,7 @@ internal void RestartFaultedStreams() | |||
| /// Starts the RtspServer and listens for requests. | |||
| /// Starts all streams contained in the server | |||
| /// </summary> | |||
| public virtual void Start(bool allowAddressReuse = false, bool allowPortReuse = false) | |||
| public virtual async Task StartAsync(bool allowAddressReuse = false, bool allowPortReuse = false) | |||
There was a problem hiding this comment.
We should probably leave the non async versions or provide a wrapper.
|
The latest code in this branch has a bug where you can no longer see the names of any test ran. I am looking to into it, it seems the changes are around |
|
I fixed it best I could for now, the Method.Name is hard to synthesize from a lambda, I don't want to spend a ton of time on such things. I will start to rebase your other commit now. If possible, in the future, please make sure all logic runs the same as before your commit (or better after a bug is fixed). Thanks again for your contributions!!! |
No description provided.