LauncherInterceptor is missing from the org.junit.platform.launcher module's uses declaration

[shartte]

Steps to reproduce

• Set junit.platform.launcher.interceptors.enabled to true
• Try running JUnit tests as modules
• Exception: Caused by: java.util.ServiceConfigurationError: org.junit.platform.launcher.LauncherInterceptor: module org.junit.platform.launcher does not declare uses

Context

• Used versions (Jupiter/Vintage/Platform): Platform 1.10.1
• Build Tool/IDE: Gradle

Probably an oversight since JUnit platform consumed as a module is an uncommon configuration.
The new Interceptor probably just needs to be added here:
https://github.com/junit-team/junit5/blob/main/junit-platform-launcher/src/module/org.junit.platform.launcher/module-info.java#L37

[sormuras]

Good catch!

I wonder why our modular compilation tests didn't catch that missing uses directive. 🤔

[shartte]

You can compile without it. It'll only throw at runtime and only if you enable the launcher interceptor configuration:

(From LauncherFactory)

if (configurationParameters.getBoolean(ENABLE_LAUNCHER_INTERCEPTORS).orElse(false)) {
	List<LauncherInterceptor> interceptors = new ArrayList<>();
	ServiceLoaderRegistry.load(LauncherInterceptor.class).forEach(interceptors::add);
	return interceptors;
}

[sormuras]

I guess javac doesn't perform the "static" check due to that we no longer use ServiceLoader.load(...) method directly:

junit5/junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/ServiceLoaderRegistry.java

Line 28 in f892e81

Iterable<T> listeners = ServiceLoader.load(serviceProviderClass, ClassLoaderUtils.getDefaultClassLoader());

[sormuras]

You can compile without it.

Sure. Yet, a warning should be emitted when running javac in modular mode and there's a ServiceLoader.load(LauncherInterceptor.class[, ...]) statement and no uses [...]LauncherInterceptor in the associated module declaration. And as we usually compile with "treat all warnings as errors" flag, it should not compile (in modular mode).

[shartte]

Ah, I was unaware of the javac warning 🤔

[sormuras]

At least, it is an IntelliJ IDEA code inspection: https://www.jetbrains.com/help/idea/list-of-java-inspections.html#visibility "Usage of service not declared in module-info"

[sormuras]

Seems like I there's no such lint warning from javac - neither javac -Xlint:module ... nor javac -Xlint:all ... emits the warning that IDEA generates. Perhaps, we can teach javac to perform a similar check. But that all can be done in parallel with your PR here.

[marcphilipp]

Reopening to backport it to 5.10.2

[sormuras]

Backported via ec8d428