Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for converting from a URI of the form method:<FQMN> to a MethodSource #1895

Closed
wants to merge 9 commits into from

Conversation

ielatif
Copy link
Contributor

@ielatif ielatif commented May 24, 2019

Overview

Introduce support for converting from a URI of the form method:<FQMN> to a MethodSource, where FQMN is the fully qualified method name. See the Javadoc for DiscoverySelectors.selectMethod(String) for the supported formats for a FQMN.

See #1850 for details


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

ielatif added 2 commits May 24, 2019 02:24
… to a MethodSource

Introduce support for converting from a URI of the form method:<FQMN> to a MethodSource, where FQMN is the fully qualified method name. See the Javadoc for DiscoverySelectors.selectMethod(String) for the supported formats for a FQMN. Closes junit-teamgh-1850
@marcphilipp marcphilipp self-requested a review May 27, 2019 11:17
@ielatif
Copy link
Contributor Author

ielatif commented May 28, 2019

@marcphilipp @sbrannen any guidelines or starting point for updating the User Guide please?

@marcphilipp
Copy link
Member

@ielatif Looks like we currently don't have any documentation for test source URIs for dynamic tests. I think a new subsection after 2.17.1. Dynamic Test Examples would make sense. I'd like to merge this PR first, though, so we can include it in 5.5 RC1 and add the documentation for 5.5 GA.

@marcphilipp marcphilipp self-assigned this May 28, 2019
@marcphilipp
Copy link
Member

@ielatif Thanks for your contribution! 👍 I've created #1903 to address the documentation in case you're interested. 😉

@ielatif
Copy link
Contributor Author

ielatif commented May 28, 2019

@marcphilipp I would be happy to 😊

@ielatif ielatif deleted the gh-1850 branch May 29, 2019 10:20
@sbrannen
Copy link
Member

+1 -- thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants