New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can I use http2 for request? #64

Closed

TheShyLeo opened this issue Mar 16, 2022 · 3 comments · Fixed by #71

Assignees

Labels

TheShyLeo commented Mar 16, 2022

I can't get any response from some APIs ,such as '/lol-match-history/v3/matchlist/account/xxxxx?begIndex=1&endIndex=10' and '/lol-matchmaking/v1/ready-check/accept',I found that I should use http2 ,but how can i do?

Owner

junlarsen commented Mar 16, 2022

The fetching library league-connect currently uses, does not support HTTP/2 at the moment (see node-fetch/node-fetch#342).

We can either wait for them to release HTTP/2 support, or we could use Node's http2 builtins. PRs are welcome

junlarsen added the enhancement label

junlarsen self-assigned this

junlarsen mentioned this issue

Implement HTTP2 Session Requests and Automatic Re-try for Socket connection #71

Merged

Owner

junlarsen commented May 26, 2022

I've implemented this under the next major version in #71

If you wish to try the new features before 6.0.0 is released, you can download 6.0.0-rc1 from npm

Author

TheShyLeo commented May 31, 2022

Thank you very much for your response！ I have solved the problem, but my code is not elegant enough, I will learn your code well, thanks again for your contribution！

junlarsen closed this as completed in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment