chore: changed smart routing page ui #2168
Open
+93
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Muditbhatia12
added
the
S-waiting-on-review
gitanjli525
reviewed
Jan 30, 2025
| </RenderIf> | ||
| <div className="mt-6"> | ||
| <div className="font-bold text-black my-2 text-lg"> | ||
| {"Smart Routing Configurations"->React.string} |
There was a problem hiding this comment.
@Muditbhatia12 The text-size and text-color of all headings does not match, can you please fix that?
gitanjli525
reviewed
Jan 30, 2025
| <TopLeftIcons routeType=value /> | ||
| <TopRightIcons routeType=value /> | ||
| </div> | ||
| <div className="flex w-full items-center flex-wrap justify-between " /> |
There was a problem hiding this comment.
this div can be removed
gitanjli525
reviewed
Jan 30, 2025
src/screens/Routing/History.res
Outdated
| @@ -1,13 +1,13 @@ | |||
| open HistoryEntity | |||
| module HistoryTable = { | |||
| @react.component | |||
| let make = (~records, ~activeRoutingIds: array<string>) => { | |||
| let make = (~records, ~activeRoutingIds: array<string>, ~customTitle) => { | |||
There was a problem hiding this comment.
can you give the default title=" ", because empty title throws error in this component
gitanjli525
reviewed
Jan 30, 2025
src/screens/Routing/History.res
Outdated
| title="History" | ||
| hideTitle=true | ||
| title={customTitle} | ||
| hideTitle=false |
There was a problem hiding this comment.
can you make value of hideTitle conditional
|
@Muditbhatia12 Verify the view in case of No rule is configured (check for a new account) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Changed smart routing page UI
Before
After
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build