Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error on sdk page when no payment connector connected #1776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: error on sdk page when no payment connector connected #1776

wants to merge 1 commit into from

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Nov 20, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

error on sdk page when no payment connector connected but other category connector are connected

current
image

fixed
image

Motivation and Context

How did you test it?

  • connect any connector other than payment connector (eg FRM, 3ds)
  • go to sdk page to try a test payment
  • it should show connect a new connector screen

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Nov 20, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner November 20, 2024 12:55
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 linked an issue Nov 20, 2024 that may be closed by this pull request
[BUG]: sdk page is showing even when no payment connector is connected #1755
Open
@gitanjli525 gitanjli525 added bug bug core Status: issues related to core S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gitanjli525 gitanjli525

Labels
bug bug core Status: issues related to core S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: sdk page is showing even when no payment connector is connected
1 participant
@gitanjli525