-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: primary color usage in components #910
Draft
vsrivatsa-edinburgh
wants to merge
5
commits into
main
Choose a base branch
from
fix/primary_color_analytics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsrivatsa-edinburgh
force-pushed
the
fix/primary_color_analytics
branch
from
July 3, 2024 13:09
310efe5
to
e2f514b
Compare
vsrivatsa-edinburgh
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
bug
bug
analytics
labels
Jul 3, 2024
JeevaRamu0104
previously approved these changes
Jul 3, 2024
vsrivatsa-edinburgh
changed the title
fix: primary color in user journey analytics
fix: primary color usage in components
Jul 3, 2024
JeevaRamu0104
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jul 9, 2024
…center into fix/primary_color_analytics
vsrivatsa-edinburgh
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Jul 10, 2024
vsrivatsa-edinburgh
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jul 10, 2024
…nto fix/primary_color_analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
analytics
bug
bug
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Dynamic primary color in components - based on config
Motivation and Context
How did you test it?
Checklist
npm run re:build