Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for card payment for Adyen connector successful flow #749

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

shubhamchasing
Copy link

@shubhamchasing shubhamchasing commented Oct 24, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Closes: hyperswitch/issues/6082

  1. Added command getIframeElement as cy.iframe as it can only be applied to exactly one iframe at a time
    edit: using cy.iframe see comment #issuecomment-2436324828
  2. Added e2e test cases for successful card payment for the Adyen connector

How did you test it?

Screenshot from 2024-10-24 07-51-44

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Oct 24, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/types.ts  100% smaller
  cypress-tests/cypress/support/utils.ts  29% smaller
  cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts  0% smaller

@shubhamchasing
Copy link
Author

@Sanskar2001 please review

@shubhamchasing
Copy link
Author

I wanna highlight one thing previously I used get because cy.iframe sometimes gives error with iframe selector .adyen-checkout__iframe, I could not find out any specific reason for it but with iframe selector .adyen-checkout__iframe--threeDSIframe it is working fine. I have made the necessary changes.

@Sanskar2001 @seekshiva please look at it, thank you!

Error while using .adyen-checkout__iframe
Screenshot from 2024-10-25 00-27-43

@gorakhnathy7 gorakhnathy7 added the Hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 25, 2024
@PritishBudhiraja PritishBudhiraja added the Testing Add this label if the PR contains Testing related changes label Oct 29, 2024
cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/fixtures/adyen3DSCardDetails.json Outdated Show resolved Hide resolved
cypress-tests/cypress/support/commands.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/support/commands.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/support/commands.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts Outdated Show resolved Hide resolved
cypress-tests/cypress/support/types.ts Outdated Show resolved Hide resolved
@shubhamchasing
Copy link
Author

I will look requested changes in a few days.

@shubhamchasing
Copy link
Author

@Sanskar2001 can you please respond to my comments, I wanna close this PR soon

@Sanskar2001
Copy link
Contributor

@Sanskar2001 can you please respond to my comments, I wanna close this PR soon

Hey @shubhamchasing, your task involved testing a normal card payment i.e. no 3DS flow meaning you don't have to test the redirection flow to Adyen Simulator. This task is assigned to someone else.

Could you please resolve the comments and take a pull from main, so that we can proceed?

Thanks!

@shubhamchasing
Copy link
Author

shubhamchasing commented Nov 12, 2024

@Sanskar2001 is there any issue from the backend because I am getting 403 error, I also tried new creds too but issue persit

@Sanskar2001
Copy link
Contributor

@Sanskar2001 is there any issue from the backend because I am getting 403 error, I also tried new creds too but issue persit

@shubhamchasing Yes, there is some maintenance going on. Please try again in some time.

@Sanskar2001
Copy link
Contributor

@Sanskar2001 is there any issue from the backend because I am getting 403 error, I also tried new creds too but issue persit

@shubhamchasing Yes, there is some maintenance going on. Please try again in some time.

@shubhamchasing The maintenance is over. You can start working on it now.

@shubhamchasing
Copy link
Author

@Sanskar2001 please review

@shubhamchasing
Copy link
Author

@Sanskar2001 @seekshiva hey guys please review

@shubhamchasing
Copy link
Author

Requested changes are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Testing Add this label if the PR contains Testing related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYPRESS] Add e2e test for card payment for Adyen Connector for a Successful Flow
4 participants