Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cypress): Add cypress test cases #4271

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Apr 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add cypress test cases for Stripe, Adyen, BankofAmerica, Cybersource, Bluesnap, Paypal, Nmi, Trustpay

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2024-04-02 at 3 32 50 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-test Category: Tests labels Apr 2, 2024
@prasunna09 prasunna09 self-assigned this Apr 2, 2024
@prasunna09 prasunna09 requested a review from a team as a code owner April 2, 2024 10:04
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

I think this folder can be removed once screenshots directory is put in /.gitignore as it affects globally. Can be ignored as it causes no harm.

Copy link
Member

@pixincreate pixincreate Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit skeptical about NMI tests being succeeded if run twice within a span of 20 mins. Once a payment is done, we would have to wait 20 mins before making a payment again, else it is marked a duplicate transaction which results in payment to fail.

On Postman though, we handle this by making the amount dynamic i.e., amount never stays the same and I do not think it is handled here in Cypress.

"metadata": {
"city": "NY",
"unit": "245",
"endpoint_prefix": "AD"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of code is specific for Adyen I believe, but will be passed for every connector?

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 06e30e0 Apr 3, 2024
9 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add-cypress-tests branch April 3, 2024 07:41
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test Category: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants