-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cypress): Add cypress test cases #4271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
I think this folder can be removed once screenshots
directory is put in /.gitignore
as it affects globally. Can be ignored as it causes no harm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit skeptical about NMI tests being succeeded if run twice within a span of 20 mins. Once a payment is done, we would have to wait 20 mins before making a payment again, else it is marked a duplicate transaction which results in payment to fail.
On Postman though, we handle this by making the amount dynamic i.e., amount never stays the same and I do not think it is handled here in Cypress.
"metadata": { | ||
"city": "NY", | ||
"unit": "245", | ||
"endpoint_prefix": "AD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of code is specific for Adyen I believe, but will be passed for every connector?
Type of Change
Description
Add cypress test cases for Stripe, Adyen, BankofAmerica, Cybersource, Bluesnap, Paypal, Nmi, Trustpay
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy