Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): fix stack overflow for docker images #4660

Merged
merged 2 commits into from
May 17, 2024
Merged

fix(docker): fix stack overflow for docker images #4660

merged 2 commits into from
May 17, 2024

Conversation

lsampras
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add a default RUST_MIN_STACK size in the docker images for router

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#4636

How did you test it?

  • generating a docker image locally and testing it

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@lsampras lsampras added A-infra Area: Infrastructure C-bug Category: Bug labels May 16, 2024
@lsampras lsampras self-assigned this May 16, 2024
@lsampras lsampras requested a review from a team as a code owner May 16, 2024 09:43
@lsampras lsampras linked an issue May 17, 2024 that may be closed by this pull request
Creating a payment will shutdown the server due to stack overflow #4666
Closed
@likhinbopanna likhinbopanna added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit a62f69d May 17, 2024
10 checks passed
@likhinbopanna likhinbopanna deleted the lsampras-fix-stack-overflow branch May 17, 2024 07:32
lsampras added a commit that referenced this pull request May 17, 2024
@lsampras
fix(docker): fix stack overflow for docker images (#4660)
6dd8a1a
@lsampras lsampras mentioned this pull request May 17, 2024
Merged
kashif-m pushed a commit that referenced this pull request May 20, 2024
@lsampras @kashif-m
fix(docker): fix stack overflow for docker images (#4660)
480f2c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivor11 ivor11 ivor11 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@lsampras lsampras

Labels
A-infra Area: Infrastructure C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a payment will shutdown the server due to stack overflow
4 participants
@lsampras @SanchithHegde @ivor11 @likhinbopanna