feat(router): add integrity check for refund refund sync and capture flow with stripe as connector #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
hrithikesh026
previously approved these changes
Jul 5, 2024
hrithikesh026
previously approved these changes
Jul 5, 2024
Narayanbhat166
previously approved these changes
Jul 5, 2024
Comment on lines
+2930
to
+2931
| let currency_enum = enums::Currency::from_str(currency.to_uppercase().as_str()) | ||
| .change_context(errors::ConnectorError::ParsingFailed)?; |
There was a problem hiding this comment.
If this check fails we will throw internal_server_error, and we won't be able to recover the payment without directly altering the DB
There was a problem hiding this comment.
correct, but this parsing failure should only happen if the currency is not supported by our application and we get that in response, Yes! we wont be able to recover this payment since its a data mismatched issue at connector end! it should be 5xx since if the issue is in hyperswitch end then we shouldn't have let the payment go through in the beginning of the request.
SamraatBansal
previously approved these changes
Jul 5, 2024
): added capture amount to sync data
sahkal
dismissed stale reviews from SamraatBansal, Narayanbhat166, and hrithikesh026
via
0e0444e
…d-refund-sync-and-capture-flow
jarnura
approved these changes
Jul 8, 2024
SamraatBansal
approved these changes
Jul 8, 2024
…d-refund-sync-and-capture-flow
hrithikesh026
approved these changes
Jul 8, 2024
hrithikesh026
approved these changes
Jul 8, 2024
…d-refund-sync-and-capture-flow
Narayanbhat166
approved these changes
Jul 8, 2024
Gnanasundari24
deleted the
5742-integrity-add-integrity-check-for-refund-refund-sync-and-capture-flow
branch
sahkal
restored the
5742-integrity-add-integrity-check-for-refund-refund-sync-and-capture-flow
branch
pixincreate
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
With this Pr we are creating integrity check for
Refund,Refund SyncandCaptureflowsMotivation and Context
This Pr holds the payment in a non-terminal state incase there is any data discrepancy in the above flows.
How did you test it?
Since it is a black box scenario it cannot is tested in sbx, until and unless we have a way to configure dummy connector to send mismatched data.
Local testing are as follows:
Capture Flow integrity checks
[Scenario 1] : Automatic capture
Steps:
Do payment create
have hardcoded the capture amount internally to fail
Now do Sync to
normal sync, to check status and error message at our end.
Status should be processing and error message should state the kind of error
Response
{ "payment_id": "pay_kW1mXPEzZmf6QZ54smCE", "merchant_id": "merchant_1719479670", "status": "processing", "amount": 6540, "net_amount": 6540, "amount_capturable": 6540, "amount_received": 6540, "connector": "stripe", "client_secret": "pay_kW1mXPEzZmf6QZ54smCE_secret_BCTKpfxKFlA7QL2WgWRI", "created": "2024-07-03T10:26:16.124Z", "currency": "USD", "customer_id": "stripesavecard_1234", "customer": { "id": "stripesavecard_1234", "name": "John Doe", "email": "[email protected]", "phone": "999999999", "phone_country_code": "+65" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": "on_session", "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "card", "payment_method_data": { "card": { "last4": "1111", "card_type": null, "card_network": null, "card_issuer": null, "card_issuing_country": null, "card_isin": "411111", "card_extended_bin": null, "card_exp_month": "03", "card_exp_year": "2030", "card_holder_name": "joseph Doe", "payment_checks": null, "authentication_data": null }, "billing": null }, "payment_token": null, "shipping": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "joseph", "last_name": "Doe" }, "phone": { "number": "8056594427", "country_code": "+91" }, "email": null }, "billing": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "joseph", "last_name": "Doe" }, "phone": { "number": "8056594427", "country_code": "+91" }, "email": null }, "order_details": null, "email": "[email protected]", "name": "John Doe", "phone": "999999999", "return_url": "https://google.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": "Integrity Check Failed! Value mismatched for fields capture_amount", "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": "credit", "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": null, "manual_retry_allowed": false, "connector_transaction_id": "pi_3PYQOCCuXDMKrYZe0WmZAbDZ", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_yl0tPMSCxxJlndl0aMHz", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_ejZeqRd80HoTTxvHokwN", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2024-07-31T11:38:41.124Z", "fingerprint": null, "browser_info": null, "payment_method_id": "pm_kVzWJzqsyZgiVe49N3rc", "payment_method_status": "active", "updated": "2024-07-03T10:26:17.975Z", "charges": null, "frm_metadata": null }check if the connector has fixed the data using force sync
if the connector has fixed it then it goes to success
[Scenario 2] : Manual capture
Do payment create
Try doing manual capture, have hardcoded it to fail
Now, do sync and lets say connector has fixed the data mismatched,
Sync
Refunds
Do payment create
Status should be 200, with succeeded
Now, do refund
The status code should be 200, with status as manual review along with error message
Now, lets say the merchant tries refund again, but since the refunds was already initiated, we shall get 400 bad request
Now, we do a sync checking if the connector as fixed the data
Checklist
cargo +nightly fmt --allcargo clippy