Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): Move connectors Bamboraapac, Boku, Gocardless, Prophetpay, Rapyd #6652

Merged
merged 9 commits into from
Dec 5, 2024
Merged

refactor(connector): Move connectors Bamboraapac, Boku, Gocardless, Prophetpay, Rapyd #6652

merged 9 commits into from
Dec 5, 2024
+1,547 −1,669

Conversation

spritianeja03
Copy link
Contributor

@spritianeja03 spritianeja03 commented Nov 25, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Moved connectors Bamboraapac, Boku, Ebanx, Gocardless, Prophetpay and Rapyd from router crate to hyperswitch_connectors crate

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Rapyd: Testing not possible because account has been deactivated

Prophetpay

  1. Merchant Account Create
curl --location 'http://localhost:8080/accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data-raw '{"merchant_id":"postman_merchant_GHAction_cb9398ef-f35f-46f1-b811-da024a94bba5","locker_id":"m0010","merchant_name":"NewAge Retailer","merchant_details":{"primary_contact_person":"John Test","primary_email":"[email protected]","primary_phone":"sunt laborum","secondary_contact_person":"John Test2","secondary_email":"[email protected]","secondary_phone":"cillum do dolor id","website":"www.example.com","about_business":"Online Retail with a wide selection of organic products for North America","address":{"line1":"1467","line2":"Harrison Street","line3":"Harrison Street","city":"San Fransico","state":"California","zip":"94122","country":"US"}},"return_url":"https://duck.com","webhook_details":{"webhook_version":"1.0.1","webhook_username":"ekart_retail","webhook_password":"password_ekart@123","payment_created_enabled":true,"payment_succeeded_enabled":true,"payment_failed_enabled":true},"sub_merchants_enabled":false,"metadata":{"city":"NY","unit":"245"},"primary_business_details":[{"country":"US","business":"default"}]}'
  1. API Key Create
curl --location 'http://localhost:8080/api_keys/postman_merchant_GHAction_c6ca85d0-9cfe-4c63-b6f8-501e3bddec30' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{"name":"API Key 1","description":null,"expiration":"2069-09-23T01:02:03.000Z"}'
  1. Payment Connector Create
curl --location 'http://localhost:8080/account/postman_merchant_GHAction_c6ca85d0-9cfe-4c63-b6f8-501e3bddec30/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
    "connector_type": "payment_processor",
    "connector_name": "prophetpay",
    "connector_account_details": {
        "auth_type": "SignatureKey",
        "api_key": "*********",
        "api_secret": "***********",
        "key1": "**********"
    },
    "business_country": "US",
    "business_label": "default",
    "test_mode": false,
    "disabled": false,
    "payment_methods_enabled": [
        {
            "payment_method": "card_redirect",
            "payment_method_types": [
                {
                    "payment_method_type": "card_redirect",
                    "payment_experience": "redirect_to_url",
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "metadata": {
        "city": "NY",
        "unit": "245"
    }
}'
  1. Payments Create
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_rkLYc4TkjKRGLZdY774ujcSF3ugQR4BNtXIET7kfST57QmW1eW7II9sTffhT2jv6' \
--data '{
    "amount": 10000,
    "currency": "USD",
    "confirm": true,
    "amount_to_capture": 10000,
    "business_country": "US",
    "customer_id": "not_a_rick_roll",
    "return_url": "https://www.google.com",
    "payment_method": "card_redirect",
    "payment_method_type": "card_redirect",
    "payment_method_data": {
        "card_redirect": {
            "card_redirect": {}
        }
    }
}'

Response

{
    "payment_id": "pay_Z4j23nC96dZRw1v9swbm",
    "merchant_id": "postman_merchant_GHAction_3bd2bcf9-fc0d-4bb3-9a92-9a7134405e12",
    "status": "requires_customer_action",
    "amount": 10000,
    "net_amount": 10000,
    "shipping_cost": null,
    "amount_capturable": 10000,
    "amount_received": null,
    "connector": "prophetpay",
    "client_secret": "pay_Z4j23nC96dZRw1v9swbm_secret_cl5RhD95NrOuiJcZCBDA",
    "created": "2024-12-03T12:17:06.875Z",
    "currency": "USD",
    "customer_id": "not_a_rick_roll",
    "customer": {
        "id": "not_a_rick_roll",
        "name": null,
        "email": null,
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": null,
    "payment_method": "card_redirect",
    "payment_method_data": {
        "card_redirect": {
            "card_redirect": {}
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": null,
    "order_details": null,
    "email": null,
    "name": null,
    "phone": null,
    "return_url": "https://www.google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_Z4j23nC96dZRw1v9swbm/postman_merchant_GHAction_3bd2bcf9-fc0d-4bb3-9a92-9a7134405e12/pay_Z4j23nC96dZRw1v9swbm_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "card_redirect",
    "connector_label": "prophetpay_US_default",
    "business_country": "US",
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "not_a_rick_roll",
        "created_at": 1733228226,
        "expires": 1733231826,
        "secret": "epk_0fd4497cec8a45009e0ee050e9496bd9"
    },
    "manual_retry_allowed": null,
    "connector_transaction_id": null,
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_0rEpfGBRM6uOaedbCVgY",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_8TGosSooBN4mvfxJMDue",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-12-03T12:32:06.875Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-12-03T12:17:07.306Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}
  1. Payments Retrieve
curl --location 'http://localhost:8080/payments/pay_Z4j23nC96dZRw1v9swbm' \
--header 'Accept: application/json' \
--header 'api-key: dev_79y4Bk6BJl0eDg66Z97SHQfKMwairDyPC5uSDw7Tk5Eycai3G6VFMx4LyBhtVDct'

Response

{
    "payment_id": "pay_Z4j23nC96dZRw1v9swbm",
    "merchant_id": "postman_merchant_GHAction_3bd2bcf9-fc0d-4bb3-9a92-9a7134405e12",
    "status": "requires_customer_action",
    "amount": 10000,
    "net_amount": 10000,
    "shipping_cost": null,
    "amount_capturable": 10000,
    "amount_received": null,
    "connector": "prophetpay",
    "client_secret": "pay_Z4j23nC96dZRw1v9swbm_secret_cl5RhD95NrOuiJcZCBDA",
    "created": "2024-12-03T12:17:06.875Z",
    "currency": "USD",
    "customer_id": "not_a_rick_roll",
    "customer": {
        "id": "not_a_rick_roll",
        "name": null,
        "email": null,
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": null,
    "payment_method": "card_redirect",
    "payment_method_data": {
        "card_redirect": {
            "card_redirect": {}
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": null,
    "order_details": null,
    "email": null,
    "name": null,
    "phone": null,
    "return_url": "https://www.google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_Z4j23nC96dZRw1v9swbm/postman_merchant_GHAction_3bd2bcf9-fc0d-4bb3-9a92-9a7134405e12/pay_Z4j23nC96dZRw1v9swbm_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "card_redirect",
    "connector_label": "prophetpay_US_default",
    "business_country": "US",
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": null,
    "connector_transaction_id": null,
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_0rEpfGBRM6uOaedbCVgY",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_8TGosSooBN4mvfxJMDue",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-12-03T12:32:06.875Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-12-03T12:17:07.306Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Bamboraapac

  1. Merchant Account Create
curl --location 'http://localhost:8080/accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data-raw '{
    "merchant_id": "merchant_1733233888",
    "locker_id": "m0010",
    "merchant_name": "NewAge Retailer",
    "primary_business_details": [
        {
            "country": "US",
            "business": "default"
        }
    ],
    "merchant_details": {
        "primary_contact_person": "John Test",
        "primary_email": "[email protected]",
        "primary_phone": "sunt laborum",
        "secondary_contact_person": "John Test2",
        "secondary_email": "[email protected]",
        "secondary_phone": "cillum do dolor id",
        "website": "www.example.com",
        "about_business": "Online Retail with a wide selection of organic products for North America",
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US"
        }
    },
    "return_url": "https://duck.com",
    "webhook_details": {
        "webhook_version": "1.0.1",
        "webhook_username": "ekart_retail",
        "webhook_password": "password_ekart@123",
        "payment_created_enabled": true,
        "payment_succeeded_enabled": true,
        "payment_failed_enabled": true
    },
    "sub_merchants_enabled": false,
    "metadata": {
        "city": "NY",
        "unit": "245"
    }
}'
  1. API Key Create
curl --location 'http://localhost:8080/api_keys/merchant_1733233863' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{"name":"API Key 1","description":null,"expiration":"2069-09-23T01:02:03.000Z"}'
  1. Payment Connector Create
curl --location 'http://localhost:8080/account/merchant_1733233863/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
    "connector_type": "payment_processor",
    "connector_name": "bamboraapac",
    "connector_account_details": {
        "auth_type": "SignatureKey",
        "api_key": "*********",
        "key1": "*******",
        "api_secret": "*******"
    },
    "test_mode": false,
    "disabled": false,
    "business_country": "US",
    "business_label": "default",
    "payment_methods_enabled": [
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "redirect_to_url",
                    "payment_method_type": "affirm"
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "redirect_to_url",
                    "payment_method_type": "afterpay_clearpay"
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "redirect_to_url",
                    "payment_method_type": "klarna"
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "invoke_sdk_client",
                    "payment_method_type": "klarna"
                }
            ]
        },
        {
            "payment_method": "bank_redirect",
            "payment_method_types": [
                {
                    "payment_method_type": "ideal",
                    "payment_experience": null,
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "giropay",
                    "payment_experience": null,
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "sofort",
                    "payment_experience": null,
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "eps",
                    "payment_experience": null,
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "bank_debit",
            "payment_method_types": [
                {
                    "payment_method_type": "ach",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "becs",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "sepa",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "bank_transfer",
            "payment_method_types": [
                {
                    "payment_method_type": "ach",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "bacs",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "sepa",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "debit",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "apple_pay",
                    "payment_experience": "invoke_sdk_client",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "google_pay",
                    "payment_experience": "invoke_sdk_client",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ]
}'
  1. Payments Create
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_IejgLBaqAy6aDD36aU1J2wUbXESWON6TZp8DgGh49jxEoPpvqEc90VWJnTlD3eTy' \
--data-raw '{
    "amount": 1050,
    "currency": "EUR",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 1050,
    "customer_id": "StripeCustomer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://duck.com",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "card_number": "4111111111111111",
            "card_exp_month": "12",
            "card_exp_year": "25",
            "card_holder_name": "joseph Doe",
            "card_cvc": "789"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "PiX"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "PiX"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}'

Response

{
    "payment_id": "pay_an7R6C8VfCRBf7yMqp5b",
    "merchant_id": "merchant_1733233863",
    "status": "succeeded",
    "amount": 1050,
    "net_amount": 1050,
    "shipping_cost": null,
    "amount_capturable": 0,
    "amount_received": 1050,
    "connector": "bamboraapac",
    "client_secret": "pay_an7R6C8VfCRBf7yMqp5b_secret_dDVP1sMzNtjFuKFk1AQx",
    "created": "2024-12-03T13:52:34.491Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "[email protected]",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1111",
            "card_type": "CREDIT",
            "card_network": "Visa",
            "card_issuer": "JP Morgan",
            "card_issuing_country": "INDIA",
            "card_isin": "411111",
            "card_extended_bin": null,
            "card_exp_month": "12",
            "card_exp_year": "25",
            "card_holder_name": null,
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "PiX",
            "last_name": null
        },
        "phone": null,
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "PiX",
            "last_name": null
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://duck.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer",
        "created_at": 1733233954,
        "expires": 1733237554,
        "secret": "epk_3ac721c706e84db8900e959681e4c4cb"
    },
    "manual_retry_allowed": false,
    "connector_transaction_id": "32645468",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "32645468",
    "payment_link": null,
    "profile_id": "pro_PWkVqhQCoj2AZwqeixJ7",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_uTwyKdYff5FC7p9kn8t7",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-12-03T14:07:34.491Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-12-03T13:52:35.943Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}
  1. Payments Retrieve
curl --location 'http://localhost:8080/payments/pay_an7R6C8VfCRBf7yMqp5b' \
--header 'Accept: application/json' \
--header 'api-key: dev_IejgLBaqAy6aDD36aU1J2wUbXESWON6TZp8DgGh49jxEoPpvqEc90VWJnTlD3eTy'

Response

{
    "payment_id": "pay_an7R6C8VfCRBf7yMqp5b",
    "merchant_id": "merchant_1733233863",
    "status": "succeeded",
    "amount": 1050,
    "net_amount": 1050,
    "shipping_cost": null,
    "amount_capturable": 0,
    "amount_received": 1050,
    "connector": "bamboraapac",
    "client_secret": "pay_an7R6C8VfCRBf7yMqp5b_secret_dDVP1sMzNtjFuKFk1AQx",
    "created": "2024-12-03T13:52:34.491Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "[email protected]",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1111",
            "card_type": "CREDIT",
            "card_network": "Visa",
            "card_issuer": "JP Morgan",
            "card_issuing_country": "INDIA",
            "card_isin": "411111",
            "card_extended_bin": null,
            "card_exp_month": "12",
            "card_exp_year": "25",
            "card_holder_name": null,
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "PiX",
            "last_name": null
        },
        "phone": null,
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "PiX",
            "last_name": null
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://duck.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "32645468",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "32645468",
    "payment_link": null,
    "profile_id": "pro_PWkVqhQCoj2AZwqeixJ7",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_uTwyKdYff5FC7p9kn8t7",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-12-03T14:07:34.491Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-12-03T13:52:35.943Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Boku: Creds not available

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 25, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector.rs  79% smaller
  crates/hyperswitch_connectors/src/connectors.rs  70% smaller
  crates/hyperswitch_connectors/src/connectors/rapyd/transformers.rs  63% smaller
  crates/hyperswitch_connectors/src/connectors/prophetpay/transformers.rs  62% smaller
  crates/hyperswitch_connectors/src/connectors/bamboraapac/transformers.rs  61% smaller
  crates/hyperswitch_connectors/src/connectors/gocardless.rs  54% smaller
  crates/hyperswitch_connectors/src/connectors/gocardless/transformers.rs  53% smaller
  crates/hyperswitch_connectors/src/connectors/rapyd.rs  52% smaller
  crates/hyperswitch_connectors/src/connectors/prophetpay.rs  52% smaller
  crates/hyperswitch_connectors/src/connectors/bamboraapac.rs  44% smaller
  crates/hyperswitch_connectors/src/connectors/boku.rs  41% smaller
  crates/hyperswitch_connectors/src/connectors/boku/transformers.rs  29% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  16% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  16% smaller
  crates/router/src/core/payments/flows.rs  16% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  16% smaller
  crates/hyperswitch_connectors/src/utils.rs  1% smaller
  Cargo.lock Unsupported file format
  crates/hyperswitch_connectors/Cargo.toml Unsupported file format
  crates/router/Cargo.toml Unsupported file format
  crates/router/src/consts.rs  0% smaller

@spritianeja03 spritianeja03 changed the title refactor(connector): Move connectors Bamboraapac, Boku, Ebanx, Gocardless, Payone, Prophetpay, Rapyd refactor(connector): Move connectors Bamboraapac, Boku, Gocardless, Prophetpay, Rapyd Nov 29, 2024
@spritianeja03 spritianeja03 self-assigned this Nov 29, 2024
@spritianeja03 spritianeja03 added C-refactor Category: Refactor A-connector-integration Area: Connector integration labels Nov 29, 2024
@spritianeja03 spritianeja03 added this to the November 2024 Release milestone Nov 29, 2024
@deepanshu-iiitu deepanshu-iiitu marked this pull request as ready for review December 2, 2024 07:53
@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners December 2, 2024 07:53
deepanshu-iiitu
deepanshu-iiitu requested changes Dec 2, 2024
View reviewed changes
crates/hyperswitch_connectors/Cargo.toml Outdated
@@ -28,6 +28,7 @@ rand = "0.8.5"
regex = "1.10.4"
reqwest = { version = "0.11.27" }
ring = "0.17.8"
roxmltree = "0.20.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this version
roxmltree = "0.19.0"

crates/hyperswitch_connectors/src/connectors/rapyd/transformers.rs Outdated
) => Self::Voided,
(RapydPaymentStatus::Error, _) => Self::Failure,
(RapydPaymentStatus::New, _) => Self::Authorizing,
// impl ForeignFrom<(RapydPaymentStatus, NextAction)> for enums::AttemptStatus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments

crates/hyperswitch_connectors/src/connectors/rapyd/transformers.rs Outdated
}
}
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments

deepanshu-iiitu
deepanshu-iiitu previously approved these changes Dec 2, 2024
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Dec 2, 2024
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Dec 2, 2024
View reviewed changes
crates/router/Cargo.toml
@@ -91,7 +91,6 @@ rdkafka = "0.36.2"
regex = "1.10.4"
reqwest = { version = "0.11.27", features = ["json", "rustls-tls", "gzip", "multipart"] }
ring = "0.17.8"
roxmltree = "0.19.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the unused dependency!

@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 36388d4 Dec 5, 2024
16 of 18 checks passed
@likhinbopanna likhinbopanna deleted the connector-movement branch December 5, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@spritianeja03 spritianeja03

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Milestone
December 2024 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@spritianeja03 @SanchithHegde @deepanshu-iiitu @Narayanbhat166 @likhinbopanna