Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: consolidate all settings in defaultProcessSettings (#348)" #379

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Oct 27, 2024

This reverts commit 1e682a8.

For context, see #348 (comment)

TODO:

  • Test failure of init scripts (wherever necessary) to avoid this mishap in the future
    • postgres

Ensuring init process from keep running because one of
`initialDatabases` or `initialScripts` failed to run
@shivaraj-bh
Copy link
Member Author

Remaining services will be tested in #383

@shivaraj-bh shivaraj-bh marked this pull request as ready for review November 4, 2024 08:40
@shivaraj-bh shivaraj-bh merged commit 9598598 into main Nov 4, 2024
2 checks passed
@shivaraj-bh shivaraj-bh deleted the revert-default-settings branch November 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant