Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertLooksLike gives false positives #1

Closed
stevenmathews opened this issue Nov 29, 2018 · 3 comments
Closed

assertLooksLike gives false positives #1

stevenmathews opened this issue Nov 29, 2018 · 3 comments

Comments

@stevenmathews
Copy link

Minimal repro

I would expect each of the 3 tests to fail, but only the third one does.

@jvanbruegge
Copy link
Owner

The first one does not fail because if the "expected" value (second argument) does not have a property, but the "actual" value is allowed to have additional properties.
The second one should fail though

@jvanbruegge
Copy link
Owner

I published a fix for the second test case as 1.0.5, I also added your example as regression test

@stevenmathews
Copy link
Author

cheers @jvanbruegge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants