mssqldef: Quote constraint name (#429)

Close #421
sqldef · Aug 22, 2023 · d1acd50 · d1acd50
1 parent 926a37e
commit d1acd50
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/cmd/mssqldef/tests.yml b/cmd/mssqldef/tests.yml
@@ -236,3 +236,13 @@ CreateViewWithMultiline:
     CREATE VIEW v AS
     SELECT
     10 as N;
+PercentConstraintName:
+  current: |
+    CREATE TABLE [dbo].[percent_test] (
+      [test%] int CONSTRAINT [DF_percent_test_test%] DEFAULT (NULL)
+    );
+  desired: |
+    CREATE TABLE [dbo].[percent_test] (
+      [test%] int CONSTRAINT [DF_percent_test_test%] DEFAULT (NULL)
+    );
+  output: ""
diff --git a/database/mssql/database.go b/database/mssql/database.go
@@ -115,7 +115,7 @@ func buildDumpTableDDL(table string, columns []column, indexDefs []*indexDef, fo
 			fmt.Fprint(&queryBuilder, " NOT NULL")
 		}
 		if col.DefaultName != "" {
-			fmt.Fprintf(&queryBuilder, " CONSTRAINT %s DEFAULT %s", col.DefaultName, col.DefaultVal)
+			fmt.Fprintf(&queryBuilder, " CONSTRAINT %s DEFAULT %s", quoteName(col.DefaultName), col.DefaultVal)
 		}
 		if col.Identity != nil {
 			fmt.Fprintf(&queryBuilder, " IDENTITY(%s,%s)", col.Identity.SeedValue, col.Identity.IncrementValue)
@@ -124,7 +124,7 @@ func buildDumpTableDDL(table string, columns []column, indexDefs []*indexDef, fo
 			}
 		}
 		if col.Check != nil {
-			fmt.Fprintf(&queryBuilder, " CONSTRAINT [%s] CHECK", col.Check.Name)
+			fmt.Fprintf(&queryBuilder, " CONSTRAINT %s CHECK", quoteName(col.Check.Name))
 			if col.Check.NotForReplication {
 				fmt.Fprint(&queryBuilder, " NOT FOR REPLICATION")
 			}
@@ -138,7 +138,7 @@ func buildDumpTableDDL(table string, columns []column, indexDefs []*indexDef, fo
 			continue
 		}
 		fmt.Fprint(&queryBuilder, ",\n"+indent)
-		fmt.Fprintf(&queryBuilder, "CONSTRAINT [%s] PRIMARY KEY", indexDef.name)
+		fmt.Fprintf(&queryBuilder, "CONSTRAINT %s PRIMARY KEY", quoteName(indexDef.name))
 
 		if indexDef.indexType == "CLUSTERED" || indexDef.indexType == "NONCLUSTERED" {
 			fmt.Fprintf(&queryBuilder, " %s", indexDef.indexType)