Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save unmodified new message as draft #4435

Closed
toreanderson opened this issue Jan 10, 2020 · 2 comments · Fixed by #4671
Closed

Do not save unmodified new message as draft #4435

toreanderson opened this issue Jan 10, 2020 · 2 comments · Fixed by #4671
Labels
type: bug Something is causing incorrect behavior or errors

Comments

@toreanderson
Copy link

Expected behavior

After having pressing the compose new message button, the compose view opens. If you close/background the app at this point, without changing/inputting anything at all, K-9 should not have saved the message as a draft.

Actual behavior

The empty new message is saved as a draft.

Steps to reproduce

  1. From the accounts view, press the compose new message button near the bottom centre of the screen (envelope icon with a little plus sign).
  2. Background the app and wait for Android to terminate it, or close it from app selection screen.
  3. Check drafts folder. An empty draft has been stored (i.e., no subject, no text, no recipients).

Environment

K-9 Mail version: 5.600

Android version: 10

Account type (IMAP, POP3, WebDAV/Exchange): IMAP

I do not believe attaching error logs is necessary in this case since this is not an application error per se, more of a UI issue.

The reason why the current behaviour is an annoyance is that the compose new button is placed so that it is easy to press it when what you want to do is to change to another app. This is because the Android 10 gesture for switching between apps is to swipe up from the bottom of the screen, and the compose new button is placed at the centre near the bottom. Thus I seem to end up accidentally entering the new message view quite frequently. If I then re-try the swipe gesture successfully immediately after, i.e., when the new message view has opened, I end up with an empty draft being saved. Because of this my drafts folder is accumulating a number of these empty drafts over time.

To me it does not seem to be any value in saving empty/unmodified drafts, so the solution is simple: just don't.

@cketti cketti added the type: bug Something is causing incorrect behavior or errors label Jan 24, 2020
@cketti
Copy link
Member

cketti commented Jan 24, 2020

Unmodified drafts are discarded by default. However, it seems that setting 'Bcc all messages to' on an identity automatically marks the message as modified.

@toreanderson
Copy link
Author

I can confirm I'm using the «Bcc all messages to» feature. Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is causing incorrect behavior or errors
Projects
None yet
2 participants