Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical dependency: the request of a dependency is an expression #57

Open
josefalcon opened this issue Feb 25, 2020 · 8 comments
Open

Comments

@josefalcon
Copy link

Using version 1.4.0 in my app built with create-react-app. I see the following warning when building or running the development server:

Compiled with warnings.

./node_modules/draftjs-md-converter/dist/index.js
Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

It doesn't appear to break anything in my app, but would be nice to suppress this warning.

@halileohalilei
Copy link

I'm having this same problem, and our build system does not let us deploy with compilation warnings, so I can't use the latest version of this library. Downgrading to 1.3.0 seems to have worked for now.

@arthureggert
Copy link

@josefalcon to me this looks like a parcel problem

There is no way to remove this warning from this repo point of view.

@kadikraman
Copy link
Owner

I finally got around to building a small demo app for this library using create react app and was able to deploy it with no issues using draftjs-md-converter@^1.4.0 so I am unable to reproduce this issue.

Perhaps this has been resolved in latest versions of create react app? The demo app is using "[email protected].

@umarjavedse
Copy link

@kadikraman
That issue is still there please provide some solution for that.

@kadikraman
Copy link
Owner

Could you please provide steps to reproduce?

@umarjavedse
Copy link

@kadikraman
Used latest version of this package even tried with old versions as but no gain.

@kadikraman
Copy link
Owner

Just released v1.5.0 which might have fixed this 🤞

@chrisgbaker
Copy link

Updating to the latest version seems to have fixed this issue 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants