Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage for apps not using Brotli compression #8

Closed
jbailey4 opened this issue Apr 17, 2019 · 2 comments · Fixed by #9
Closed

Usage for apps not using Brotli compression #8

jbailey4 opened this issue Apr 17, 2019 · 2 comments · Fixed by #9
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jbailey4
Copy link
Contributor

jbailey4 commented Apr 17, 2019

Thanks for the great addon!

Could there be a way to make brotli-size an optional dependency for those that only use gzip exclusively in their projects? This dep pulls in iltorb which requires native OS bindings, and while this is possible to set up, it requires extra effort to configure for CI for something that isn't relevant for the consuming app.

Similar issues: siddharthkp/bundlesize#202

@simonihmig
Copy link
Member

Thanks @jbailey4 for this suggestion, I agree it makes sense!

The approach could be similar to siddharthkp/bundlesize#220, i.e. remove the package from dependencies, check when running the test command that brotli is not used in the configuration, or if it is that brotli-size is available, otherwise fail with an error message like Please install brotli-size if you want to use ember-cli-bundlesize with Brotli.

Would you eventually be interested in contributing this PR?

@simonihmig simonihmig added enhancement New feature or request help wanted Extra attention is needed labels Apr 30, 2019
@jbailey4
Copy link
Contributor Author

@simonihmig Sure! Thanks for the suggestions. I'll try to find some time this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants