You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could there be a way to make brotli-size an optional dependency for those that only use gzip exclusively in their projects? This dep pulls in iltorb which requires native OS bindings, and while this is possible to set up, it requires extra effort to configure for CI for something that isn't relevant for the consuming app.
Thanks @jbailey4 for this suggestion, I agree it makes sense!
The approach could be similar to siddharthkp/bundlesize#220, i.e. remove the package from dependencies, check when running the test command that brotli is not used in the configuration, or if it is that brotli-size is available, otherwise fail with an error message like Please install brotli-size if you want to use ember-cli-bundlesize with Brotli.
Would you eventually be interested in contributing this PR?
Thanks for the great addon!
Could there be a way to make
brotli-size
an optional dependency for those that only usegzip
exclusively in their projects? This dep pulls iniltorb
which requires native OS bindings, and while this is possible to set up, it requires extra effort to configure for CI for something that isn't relevant for the consuming app.Similar issues: siddharthkp/bundlesize#202
The text was updated successfully, but these errors were encountered: