You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently BaseObj accepts any keyword args, even ones not defined via self.need() or self.optional(). This means that any unknown keywords will blindly have no effect.
We should make BaseObj check keywords against the ones set in self.need and self.optional() and raise an Exception on unknown keywords.
And maybe do this via a new BaseObjStrict class, as the original BaseObj behaviour might be needed in some use cases (like passing keyword params via the inventory, where it's not ideal to hardcode all params via self.need() or self.optional().
The text was updated successfully, but these errors were encountered:
Currently
BaseObj
accepts any keyword args, even ones not defined viaself.need()
orself.optional()
. This means that any unknown keywords will blindly have no effect.We should make
BaseObj
check keywords against the ones set inself.need
andself.optional()
and raise an Exception on unknown keywords.And maybe do this via a new
BaseObjStrict
class, as the originalBaseObj
behaviour might be needed in some use cases (like passing keyword params via the inventory, where it's not ideal to hardcode all params viaself.need()
orself.optional()
.The text was updated successfully, but these errors were encountered: